]> gitweb.ps.run Git - ps-cgit/commitdiff
do not infloop on a query ending in %XY, for invalid hex X or Y
authorJim Meyering <meyering@redhat.com>
Mon, 28 Feb 2011 11:18:57 +0000 (12:18 +0100)
committerLars Hjemli <hjemli@gmail.com>
Sat, 5 Mar 2011 12:38:34 +0000 (13:38 +0100)
When a query ends in say %gg, (or any invalid hex) e.g.,
http://git.gnome.org/browse/gdlmm/commit/?id=%gg
convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns
txt-1, so the loop in http_parse_querystring never terminates.  The
solution is to make the memmove also copy the trailing NUL.
* html.c (convert_query_hexchar): Fix off-by-one error.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

No differences found