From: Jim Meyering Date: Mon, 28 Feb 2011 11:18:57 +0000 (+0100) Subject: do not infloop on a query ending in %XY, for invalid hex X or Y X-Git-Url: https://gitweb.ps.run/ps-cgit/commitdiff_plain/fc384b16fb9787380746000d3cea2d53fccc548e?hp=fc384b16fb9787380746000d3cea2d53fccc548e do not infloop on a query ending in %XY, for invalid hex X or Y When a query ends in say %gg, (or any invalid hex) e.g., http://git.gnome.org/browse/gdlmm/commit/?id=%gg convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns txt-1, so the loop in http_parse_querystring never terminates. The solution is to make the memmove also copy the trailing NUL. * html.c (convert_query_hexchar): Fix off-by-one error. Signed-off-by: Lars Hjemli ---