ui-refs.c: Remove global header variable

print_tag_header() is only called from cgit_print_tags() -- the
conditional invocation in print_tag() is never executed since
print_tag() is only called by cgit_print_tags() which already executes
print_tag_header() before (resulting in the global variable being always
set in when the condition is evaluated).

Remove the global variable and the conditional invocation.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>

diff --git a/ui-refs.c b/ui-refs.c
index 5bebed1e7521490c5ae8d04157e2a8b5695f6337..0399e6b9ebc05f87e6f1bffc1281965d26015ad3 100644 (file)
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -11,8 +11,6 @@
 #include "html.h"
 #include "ui-shared.h"
 
 #include "html.h"
 #include "ui-shared.h"
 

-static int header;
-

 static int cmp_age(int age1, int age2)
 {
        if (age1 != 0 && age2 != 0)
 static int cmp_age(int age1, int age2)
 {
        if (age1 != 0 && age2 != 0)


@@ -96,7 +94,6 @@ static void print_tag_header()
             "<th class='left'>Download</th>"
             "<th class='left'>Author</th>"
             "<th class='left' colspan='2'>Age</th></tr>\n");
             "<th class='left'>Download</th>"
             "<th class='left'>Author</th>"
             "<th class='left' colspan='2'>Age</th></tr>\n");

-       header = 1;

 }
 
 static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 }
 
 static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)


@@ -156,8 +153,6 @@ static int print_tag(struct refinfo *ref)
                        cgit_print_age(info->tagger_date, -1, NULL);
                html("</td></tr>\n");
        } else {
                        cgit_print_age(info->tagger_date, -1, NULL);
                html("</td></tr>\n");
        } else {

-               if (!header)
-                       print_tag_header();

                html("<tr><td>");
                cgit_tag_link(name, NULL, NULL, ctx.qry.head, name);
                html("</td><td>");
                html("<tr><td>");
                cgit_tag_link(name, NULL, NULL, ctx.qry.head, name);
                html("</td><td>");


@@ -221,7 +216,6 @@ void cgit_print_tags(int maxcount)
        struct reflist list;
        int i;
 
        struct reflist list;
        int i;
 

-       header = 0;

        list.refs = NULL;
        list.alloc = list.count = 0;
        for_each_tag_ref(cgit_refs_cb, &list);
        list.refs = NULL;
        list.alloc = list.count = 0;
        for_each_tag_ref(cgit_refs_cb, &list);