t0109: test more URLs

In order to ensure that we don't access $HOME at some point after
initial startup when rendering a specific view, run the strace test on a
range of different pages.

This ensures that we don't end up reading a configuration later for some
specific view.

Signed-off-by: John Keeping <john@keeping.me.uk>

diff --git a/tests/t0109-gitconfig.sh b/tests/t0109-gitconfig.sh
index f64e691b6ddabc08075684df4525bef335880998..24b2942f260d8201782f2c82d1cf0b1e7fff9120 100755 (executable)
--- a/tests/t0109-gitconfig.sh
+++ b/tests/t0109-gitconfig.sh
@@ -9,17 +9,33 @@ test -n "$(which strace 2>/dev/null)" || {
        exit
 }
 
        exit
 }
 

-test_expect_success 'no access to $HOME' '
+test_no_home_access () {

        non_existant_path="/path/to/some/place/that/does/not/possibly/exist"
        while test -d "$non_existant_path"; do
                non_existant_path="$non_existant_path/$(date +%N)"
        non_existant_path="/path/to/some/place/that/does/not/possibly/exist"
        while test -d "$non_existant_path"; do
                non_existant_path="$non_existant_path/$(date +%N)"

-       done
+       done &&

        strace \
                -E HOME="$non_existant_path" \
                -E CGIT_CONFIG="$PWD/cgitrc" \
        strace \
                -E HOME="$non_existant_path" \
                -E CGIT_CONFIG="$PWD/cgitrc" \

-               -E QUERY_STRING="url=foo/commit" \
+               -E QUERY_STRING="url=$1" \

                -e access -f -o strace.out cgit &&
        test_must_fail grep "$non_existant_path" strace.out
                -e access -f -o strace.out cgit &&
        test_must_fail grep "$non_existant_path" strace.out

-'
+}
+
+function test_no_home_access_success() {
+       test_expect_success "do not access \$HOME: $1" "
+               test_no_home_access '$1'
+       "
+}
+
+test_no_home_access_success
+test_no_home_access_success foo
+test_no_home_access_success foo/refs
+test_no_home_access_success foo/log
+test_no_home_access_success foo/tree
+test_no_home_access_success foo/tree/file-1
+test_no_home_access_success foo/commit
+test_no_home_access_success foo/diff
+test_no_home_access_success foo/patch

 
 test_done
 
 test_done