Merge branch 'lh/embedded'

Conflicts:
	cgitrc.5.txt
	ui-shared.c

diff --git a/.gitignore b/.gitignore
index 1e016e5a7af46cd1542695a8c363d66db6d34c68..487728b0a37d9bb96b0ea58f78f0165c92b84df4 100644 (file)
--- a/.gitignore
+++ b/.gitignore
@@ -2,5 +2,10 @@
 cgit
 cgit.conf
 VERSION
+cgitrc.5
+cgitrc.5.fo
+cgitrc.5.html
+cgitrc.5.pdf
+cgitrc.5.xml
 *.o
 *.d

diff --git a/Makefile b/Makefile
index 0f0089afd8cb489f9c4906550b1c3785a9a61f8c..707d4462a778606e1591adaad41e2d555e255dfa 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-CGIT_VERSION = v0.8.2
+CGIT_VERSION = v0.8.2.1
 CGIT_SCRIPT_NAME = cgit.cgi
 CGIT_SCRIPT_PATH = /var/www/htdocs/cgit
 CGIT_DATA_PATH = $(CGIT_SCRIPT_PATH)
@@ -100,7 +100,8 @@ ifdef NEEDS_LIBICONV
 endif
 
 
-.PHONY: all libgit test install uninstall clean force-version get-git
+.PHONY: all libgit test install uninstall clean force-version get-git \
+       doc man-doc html-doc clean-doc
 
 all: cgit
 
@@ -149,8 +150,22 @@ uninstall:
        rm -f $(CGIT_DATA_PATH)/cgit.css
        rm -f $(CGIT_DATA_PATH)/cgit.png
 
-clean:
+doc: man-doc html-doc pdf-doc
+
+man-doc: cgitrc.5.txt
+       a2x -f manpage cgitrc.5.txt
+
+html-doc: cgitrc.5.txt
+       a2x -f xhtml --stylesheet=cgit-doc.css cgitrc.5.txt
+
+pdf-doc: cgitrc.5.txt
+       a2x -f pdf cgitrc.5.txt
+
+clean: clean-doc
        rm -f cgit VERSION *.o *.d
 
+clean-doc:
+       rm -f cgitrc.5 cgitrc.5.html cgitrc.5.pdf cgitrc.5.xml cgitrc.5.fo
+
 get-git:
        curl $(GIT_URL) | tar -xj && rm -rf git && mv git-$(GIT_VER) git

diff --git a/cgit-doc.css b/cgit-doc.css
new file mode 100644 (file)
index 0000000..5a399b6
--- /dev/null
+++ b/cgit-doc.css
@@ -0,0 +1,3 @@
+div.variablelist dt {
+       margin-top: 1em;
+}

diff --git a/cgit.c b/cgit.c
index 38f0fdda6c3d76bca1fe7dd0734253b1f9ac4529..2039ab1de53699b6d29a23f1409461386589a227 100644 (file)
--- a/cgit.c
+++ b/cgit.c
@@ -31,6 +31,8 @@ void config_cb(const char *name, const char *value)
                ctx.cfg.favicon = xstrdup(value);
        else if (!strcmp(name, "footer"))
                ctx.cfg.footer = xstrdup(value);
+       else if (!strcmp(name, "head-include"))
+               ctx.cfg.head_include = xstrdup(value);
        else if (!strcmp(name, "header"))
                ctx.cfg.header = xstrdup(value);
        else if (!strcmp(name, "logo"))
@@ -210,6 +212,7 @@ static void prepare_context(struct cgit_context *ctx)
        ctx->page.size = 0;
        ctx->page.modified = time(NULL);
        ctx->page.expires = ctx->page.modified;
+       ctx->page.etag = NULL;
 }
 
 struct refmatch {
@@ -289,6 +292,8 @@ static int prepare_repo_cmd(struct cgit_context *ctx)
        if (get_sha1(ctx->qry.head, sha1)) {
                tmp = xstrdup(ctx->qry.head);
                ctx->qry.head = ctx->repo->defbranch;
+               ctx->page.status = 404;
+               ctx->page.statusmsg = "not found";
                cgit_print_http_headers(ctx);
                cgit_print_docstart(ctx);
                cgit_print_pageheader(ctx);
@@ -433,6 +438,7 @@ static int calc_ttl()
 int main(int argc, const char **argv)
 {
        const char *cgit_config_env = getenv("CGIT_CONFIG");
+       const char *method = getenv("REQUEST_METHOD");
        const char *path;
        char *qry;
        int err, ttl;
@@ -479,6 +485,8 @@ int main(int argc, const char **argv)
 
        ttl = calc_ttl();
        ctx.page.expires += ttl*60;
+       if (method && !strcmp(method, "HEAD"))
+               ctx.cfg.nocache = 1;
        if (ctx.cfg.nocache)
                ctx.cfg.cache_size = 0;
        err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root,

diff --git a/cgit.h b/cgit.h
index ca01705953a489760cc6b625a13919af20e3e0db..8c64efeaa6e7f5698751e202b64765280e3985cf 100644 (file)
--- a/cgit.h
+++ b/cgit.h
@@ -136,6 +136,7 @@ struct cgit_config {
        char *css;
        char *favicon;
        char *footer;
+       char *head_include;
        char *header;
        char *index_header;
        char *index_info;
@@ -182,7 +183,10 @@ struct cgit_page {
        char *mimetype;
        char *charset;
        char *filename;
+       char *etag;
        char *title;
+       int status;
+       char *statusmsg;
 };
 
 struct cgit_context {

diff --git a/cgitrc.5.txt b/cgitrc.5.txt
index 771bb7dfcfd5b3783c40c302344d8998ef337a6e..a207fe07aadb9eb2863b1c47165e804772a12e5b 100644 (file)
--- a/cgitrc.5.txt
+++ b/cgitrc.5.txt
@@ -1,14 +1,14 @@
-CGITRC
-======
+CGITRC(5)
+========
 
 
 NAME
 ----
-       cgitrc - runtime configuration for cgit
+cgitrc - runtime configuration for cgit
 
 
-DESCRIPTION
------------
+SYNOPSIS
+--------
 Cgitrc contains all runtime settings for cgit, including the list of git
 repositories, formatted as a line-separated list of NAME=VALUE pairs. Blank
 lines, and lines starting with '#', are ignored.
@@ -16,175 +16,179 @@ lines, and lines starting with '#', are ignored.
 
 GLOBAL SETTINGS
 ---------------
-agefile
+agefile::
        Specifies a path, relative to each repository path, which can be used
        to specify the date and time of the youngest commit in the repository.
        The first line in the file is used as input to the "parse_date"
        function in libgit. Recommended timestamp-format is "yyyy-mm-dd
        hh:mm:ss". Default value: "info/web/last-modified".
 
-cache-root
+cache-root::
        Path used to store the cgit cache entries. Default value:
        "/var/cache/cgit".
 
-cache-dynamic-ttl
+cache-dynamic-ttl::
        Number which specifies the time-to-live, in minutes, for the cached
        version of repository pages accessed without a fixed SHA1. Default
        value: "5".
 
-cache-repo-ttl
+cache-repo-ttl::
        Number which specifies the time-to-live, in minutes, for the cached
        version of the repository summary page. Default value: "5".
 
-cache-root-ttl
+cache-root-ttl::
        Number which specifies the time-to-live, in minutes, for the cached
        version of the repository index page. Default value: "5".
 
-cache-size
+cache-size::
        The maximum number of entries in the cgit cache. Default value: "0"
        (i.e. caching is disabled).
 
-cache-static-ttl
+cache-static-ttl::
        Number which specifies the time-to-live, in minutes, for the cached
        version of repository pages accessed with a fixed SHA1. Default value:
        "5".
 
-clone-prefix
+clone-prefix::
        Space-separated list of common prefixes which, when combined with a
        repository url, generates valid clone urls for the repository. This
        setting is only used if `repo.clone-url` is unspecified. Default value:
        none.
 
-css
+css::
        Url which specifies the css document to include in all cgit pages.
        Default value: "/cgit.css".
 
-embedded
+embedded::
        Flag which, when set to "1", will make cgit generate a html fragment
        suitable for embedding in other html pages. Default value: none. See
        also: "noheader".
        
-enable-index-links
+enable-index-links::
        Flag which, when set to "1", will make cgit generate extra links for
        each repo in the repository index (specifically, to the "summary",
        "commit" and "tree" pages). Default value: "0".
 
-enable-log-filecount
+enable-log-filecount::
        Flag which, when set to "1", will make cgit print the number of
        modified files for each commit on the repository log page. Default
        value: "0".
 
-enable-log-linecount
+enable-log-linecount::
        Flag which, when set to "1", will make cgit print the number of added
        and removed lines for each commit on the repository log page. Default
        value: "0".
 
-favicon
+favicon::
        Url used as link to a shortcut icon for cgit. If specified, it is
        suggested to use the value "/favicon.ico" since certain browsers will
        ignore other values. Default value: none.
 
-footer
+footer::
        The content of the file specified with this option will be included
        verbatim at the bottom of all pages (i.e. it replaces the standard
        "generated by..." message. Default value: none.
 
-header
+head-include::
+       The content of the file specified with this option will be included
+       verbatim in the html HEAD section on all pages. Default value: none.
+
+header::
        The content of the file specified with this option will be included
        verbatim at the top of all pages. Default value: none.
 
-include
+include::
        Name of a configfile to include before the rest of the current config-
        file is parsed. Default value: none.
 
-index-header
+index-header::
        The content of the file specified with this option will be included
        verbatim above the repository index. This setting is deprecated, and
        will not be supported by cgit-1.0 (use root-readme instead). Default
        value: none.
 
-index-info
+index-info::
        The content of the file specified with this option will be included
        verbatim below the heading on the repository index page. This setting
        is deprecated, and will not be supported by cgit-1.0 (use root-desc
        instead). Default value: none.
 
-local-time
+local-time::
        Flag which, if set to "1", makes cgit print commit and tag times in the
        servers timezone. Default value: "0".
 
-logo
+logo::
        Url which specifies the source of an image which will be used as a logo
        on all cgit pages.
 
-logo-link
+logo-link::
        Url loaded when clicking on the cgit logo image. If unspecified the
        calculated url of the repository index page will be used. Default
        value: none.
 
-max-commit-count
+max-commit-count::
        Specifies the number of entries to list per page in "log" view. Default
        value: "50".
 
-max-message-length
+max-message-length::
        Specifies the maximum number of commit message characters to display in
        "log" view. Default value: "80".
 
-max-repo-count
+max-repo-count::
        Specifies the number of entries to list per page on the repository
        index page. Default value: "50".
 
-max-repodesc-length
+max-repodesc-length::
        Specifies the maximum number of repo description characters to display
        on the repository index page. Default value: "80".
 
-max-stats
+max-stats::
        Set the default maximum statistics period. Valid values are "week",
        "month", "quarter" and "year". If unspecified, statistics are
        disabled. Default value: none. See also: "repo.max-stats".
 
-module-link
+module-link::
        Text which will be used as the formatstring for a hyperlink when a
        submodule is printed in a directory listing. The arguments for the
        formatstring are the path and SHA1 of the submodule commit. Default
        value: "./?repo=%s&page=commit&id=%s"
 
-nocache
+nocache::
        If set to the value "1" caching will be disabled. This settings is
        deprecated, and will not be honored starting with cgit-1.0. Default
        value: "0".
 
-noheader
+noheader::
        Flag which, when set to "1", will make cgit omit the standard header
        on all pages. Default value: none. See also: "embedded".
 
-renamelimit
+renamelimit::
        Maximum number of files to consider when detecting renames. The value
         "-1" uses the compiletime value in git (for further info, look at
          `man git-diff`). Default value: "-1".
 
-repo.group
+repo.group::
        A value for the current repository group, which all repositories
        specified after this setting will inherit. Default value: none.
 
-robots
+robots::
        Text used as content for the "robots" meta-tag. Default value:
        "index, nofollow".
 
-root-desc
+root-desc::
        Text printed below the heading on the repository index page. Default
        value: "a fast webinterface for the git dscm".
 
-root-readme:
+root-readme::
        The content of the file specified with this option will be included
        verbatim below the "about" link on the repository index page. Default
        value: none.
 
-root-title
+root-title::
        Text printed as heading on the repository index page. Default value:
        "Git Repository Browser".
 
-snapshots
+snapshots::
        Text which specifies the default (and allowed) set of snapshot formats
        supported by cgit. The value is a space-separated list of zero or more
        of the following values:
@@ -194,19 +198,19 @@ snapshots
                "zip"           zip-file
        Default value: none.
 
-summary-branches
+summary-branches::
        Specifies the number of branches to display in the repository "summary"
        view. Default value: "10".
 
-summary-log
+summary-log::
        Specifies the number of log entries to display in the repository
        "summary" view. Default value: "10".
 
-summary-tags
+summary-tags::
        Specifies the number of tags to display in the repository "summary"
        view. Default value: "10".
 
-virtual-root
+virtual-root::
        Url which, if specified, will be used as root for all cgit links. It
        will also cause cgit to generate 'virtual urls', i.e. urls like
        '/cgit/tree/README' as opposed to '?r=cgit&p=tree&path=README'. Default
@@ -216,51 +220,51 @@ virtual-root
 
 REPOSITORY SETTINGS
 -------------------
-repo.clone-url
+repo.clone-url::
        A list of space-separated urls which can be used to clone this repo.
        Default value: none.
 
-repo.defbranch
+repo.defbranch::
        The name of the default branch for this repository. If no such branch
        exists in the repository, the first branch name (when sorted) is used
        as default instead. Default value: "master".
 
-repo.desc
+repo.desc::
        The value to show as repository description. Default value: none.
 
-repo.enable-log-filecount
+repo.enable-log-filecount::
        A flag which can be used to disable the global setting
        `enable-log-filecount'. Default value: none.
 
-repo.enable-log-linecount
+repo.enable-log-linecount::
        A flag which can be used to disable the global setting
        `enable-log-linecount'. Default value: none.
 
-repo.max-stats
+repo.max-stats::
        Override the default maximum statistics period. Valid values are equal
        to the values specified for the global "max-stats" setting. Default
        value: none.
 
-repo.name
+repo.name::
        The value to show as repository name. Default value: <repo.url>.
 
-repo.owner
+repo.owner::
        A value used to identify the owner of the repository. Default value:
        none.
 
-repo.path
+repo.path::
        An absolute path to the repository directory. For non-bare repositories
        this is the .git-directory. Default value: none.
 
-repo.readme
+repo.readme::
        A path (relative to <repo.path>) which specifies a file to include
        verbatim as the "About" page for this repo. Default value: none.
 
-repo.snapshots
+repo.snapshots::
        A mask of allowed snapshot-formats for this repo, restricted by the
        "snapshots" global setting. Default value: <snapshots>.
 
-repo.url
+repo.url::
        The relative url used to access the repository. This must be the first
        setting specified for each repo. Default value: none.
 
@@ -268,6 +272,7 @@ repo.url
 EXAMPLE CGITRC FILE
 -------------------
 
+....
 # Enable caching of up to 1000 output entriess
 cache-size=1000
 
@@ -377,6 +382,7 @@ repo.enable-log-linecount=0
 
 # Restrict the max statistics period for this repo
 repo.max-stats=month
+....
 
 
 BUGS

diff --git a/ui-atom.c b/ui-atom.c
index a6ea3eecf58ec6fd0db3aab018522ecca5e98acd..e5c31d9dd066fd7e7a63da846ab6add0b9aea0e6 100644 (file)
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -52,7 +52,8 @@ void add_entry(struct commit *commit, char *host)
        cgit_print_date(info->author_date, FMT_ATOMDATE, ctx.cfg.local_time);
        html("</published>\n");
        if (host) {
-               html("<link rel='alternate' type='text/html' href='http://");
+               html("<link rel='alternate' type='text/html' href='");
+               html(cgit_httpscheme());
                html_attr(host);
                html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL));
                if (ctx.cfg.virtual_root)
@@ -113,7 +114,8 @@ void cgit_print_atom(char *tip, char *path, int max_count)
        html_txt(ctx.repo->desc);
        html("</subtitle>\n");
        if (host) {
-               html("<link rel='alternate' type='text/html' href='http://");
+               html("<link rel='alternate' type='text/html' href='");
+               html(cgit_httpscheme());
                html_attr(host);
                html_attr(cgit_repourl(ctx.repo->url));
                html("'/>\n");

diff --git a/ui-blob.c b/ui-blob.c
index 3cda03d37992e987a3000613b01d6d7ac325db18..2ccd31d2a19e5df1651cf2efff5952254cb3a0ad 100644 (file)
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -27,7 +27,7 @@ void cgit_print_blob(const char *hex, char *path, const char *head)
 
        unsigned char sha1[20];
        enum object_type type;
-       unsigned char *buf;
+       char *buf;
        unsigned long size;
        struct commit *commit;
        const char *paths[] = {path, NULL};
@@ -67,6 +67,12 @@ void cgit_print_blob(const char *hex, char *path, const char *head)
 
        buf[size] = '\0';
        ctx.page.mimetype = ctx.qry.mimetype;
+       if (!ctx.page.mimetype) {
+               if (buffer_is_binary(buf, size))
+                       ctx.page.mimetype = "application/octet-stream";
+               else
+                       ctx.page.mimetype = "text/plain";
+       }
        ctx.page.filename = path;
        cgit_print_http_headers(&ctx);
        write(htmlfd, buf, size);

diff --git a/ui-plain.c b/ui-plain.c
index 5addd9e686539ca41f264394ecf6836aa739af4e..93a3a05ac50f7a43b3c50529a011f0c9fdbf547c 100644 (file)
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -31,9 +31,13 @@ static void print_object(const unsigned char *sha1, const char *path)
                html_status(404, "Not found", 0);
                return;
        }
-       ctx.page.mimetype = "text/plain";
+       if (buffer_is_binary(buf, size))
+               ctx.page.mimetype = "application/octet-stream";
+       else
+               ctx.page.mimetype = "text/plain";
        ctx.page.filename = fmt("%s", path);
        ctx.page.size = size;
+       ctx.page.etag = sha1_to_hex(sha1);
        cgit_print_http_headers(&ctx);
        html_raw(buf, size);
        match = 1;

diff --git a/ui-shared.c b/ui-shared.c
index 5e03a7a52ef7697f039b684f2fc1779fecbb9270..015c52b6c044f2a280ca7259c68c6d6f5040711b 100644 (file)
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -34,6 +34,17 @@ void cgit_print_error(char *msg)
        html("</div>\n");
 }
 
+char *cgit_httpscheme()
+{
+       char *https;
+
+       https = getenv("HTTPS");
+       if (https != NULL && strcmp(https, "on") == 0)
+               return "https://";
+       else
+               return "http://";
+}
+
 char *cgit_hosturl()
 {
        char *host, *port;
@@ -456,9 +467,13 @@ void cgit_print_age(time_t t, time_t max_relative, char *format)
 
 void cgit_print_http_headers(struct cgit_context *ctx)
 {
+       const char *method = getenv("REQUEST_METHOD");
+
        if (ctx->cfg.embedded)
                return;
 
+       if (ctx->page.status)
+               htmlf("Status: %d %s\n", ctx->page.status, ctx->page.statusmsg);
        if (ctx->page.mimetype && ctx->page.charset)
                htmlf("Content-Type: %s; charset=%s\n", ctx->page.mimetype,
                      ctx->page.charset);
@@ -471,7 +486,11 @@ void cgit_print_http_headers(struct cgit_context *ctx)
                      ctx->page.filename);
        htmlf("Last-Modified: %s\n", http_date(ctx->page.modified));
        htmlf("Expires: %s\n", http_date(ctx->page.expires));
+       if (ctx->page.etag)
+               htmlf("ETag: \"%s\"\n", ctx->page.etag);
        html("\n");
+       if (method && !strcmp(method, "HEAD"))
+               exit(0);
 }
 
 void cgit_print_docstart(struct cgit_context *ctx)
@@ -498,12 +517,15 @@ void cgit_print_docstart(struct cgit_context *ctx)
                html("'/>\n");
        }
        if (host && ctx->repo) {
-               html("<link rel='alternate' title='Atom feed' href='http://");
+               html("<link rel='alternate' title='Atom feed' href='");
+               html(cgit_httpscheme());
                html_attr(cgit_hosturl());
                html_attr(cgit_fileurl(ctx->repo->url, "atom", ctx->qry.path,
                                       fmt("h=%s", ctx->qry.head)));
-               html("' type='application/atom+xml'/>");
+               html("' type='application/atom+xml'/>\n");
        }
+       if (ctx->cfg.head_include)
+               html_include(ctx->cfg.head_include);
        html("</head>\n");
        html("<body>\n");
        if (ctx->cfg.header)

diff --git a/ui-shared.h b/ui-shared.h
index 5a3821f20e1e973f1446845d2641f5e5bc13f5a1..bff482604428c201e3a3c4c2d07d2642923a23f3 100644 (file)
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -1,6 +1,7 @@
 #ifndef UI_SHARED_H
 #define UI_SHARED_H
 
+extern char *cgit_httpscheme();
 extern char *cgit_hosturl();
 extern char *cgit_repourl(const char *reponame);
 extern char *cgit_fileurl(const char *reponame, const char *pagename,

diff --git a/ui-snapshot.c b/ui-snapshot.c
index f25613e9d6c98530e48c1814305000d22ebbb44f..5372f5d3d8b42a474713fe0867f4b50d96f5acf1 100644 (file)
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -156,20 +156,31 @@ static const char *get_ref_from_filename(const char *url, const char *filename,
        return NULL;
 }
 
+void show_error(char *msg)
+{
+       ctx.page.mimetype = "text/html";
+       cgit_print_http_headers(&ctx);
+       cgit_print_docstart(&ctx);
+       cgit_print_pageheader(&ctx);
+       cgit_print_error(msg);
+       cgit_print_docend();
+}
+
 void cgit_print_snapshot(const char *head, const char *hex,
                         const char *filename, int snapshots, int dwim)
 {
        const struct cgit_snapshot_format* f;
        char *prefix = NULL;
 
+       if (!filename) {
+               show_error("No snapshot name specified");
+               return;
+       }
+
        f = get_format(filename);
        if (!f) {
-               ctx.page.mimetype = "text/html";
-               cgit_print_http_headers(&ctx);
-               cgit_print_docstart(&ctx);
-               cgit_print_pageheader(&ctx);
-               cgit_print_error(fmt("Unsupported snapshot format: %s", filename));
-               cgit_print_docend();
+               show_error(xstrdup(fmt("Unsupported snapshot format: %s",
+                                      filename)));
                return;
        }
 

diff --git a/ui-tree.c b/ui-tree.c
index a37a4e59c56f1bfcbe057bb7dde74abfe272e146..553dbaa5a27e60ebad594d23cc842895bdf4beed 100644 (file)
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -25,11 +25,14 @@ static void print_text_buffer(char *buf, unsigned long size)
        html("<tr><td class='linenumbers'><pre>");
        idx = 0;
        lineno = 0;
-       htmlf(numberfmt, ++lineno);
-       while(idx < size - 1) { // skip absolute last newline
-               if (buf[idx] == '\n')
-                       htmlf(numberfmt, ++lineno);
-               idx++;
+
+       if (size) {
+               htmlf(numberfmt, ++lineno);
+               while(idx < size - 1) { // skip absolute last newline
+                       if (buf[idx] == '\n')
+                               htmlf(numberfmt, ++lineno);
+                       idx++;
+               }
        }
        html("</pre></td>\n");
        html("<td class='lines'><pre><code>");
@@ -37,21 +40,26 @@ static void print_text_buffer(char *buf, unsigned long size)
        html("</code></pre></td></tr></table>\n");
 }
 
+#define ROWLEN 32
+
 static void print_binary_buffer(char *buf, unsigned long size)
 {
        unsigned long ofs, idx;
+       static char ascii[ROWLEN + 1];
 
        html("<table summary='blob content' class='bin-blob'>\n");
        html("<tr><th>ofs</th><th>hex dump</th><th>ascii</th></tr>");
-       for (ofs = 0; ofs < size; ofs += 32, buf += 32) {
+       for (ofs = 0; ofs < size; ofs += ROWLEN, buf += ROWLEN) {
                htmlf("<tr><td class='right'>%04x</td><td class='hex'>", ofs);
-               for (idx = 0; idx < 32 && ofs + idx < size; idx++)
+               for (idx = 0; idx < ROWLEN && ofs + idx < size; idx++)
                        htmlf("%*s%02x",
                              idx == 16 ? 4 : 1, "",
                              buf[idx] & 0xff);
                html(" </td><td class='hex'>");
-               for (idx = 0; idx < 32 && ofs + idx < size; idx++)
-                       htmlf("%c", isgraph(buf[idx]) ? buf[idx] : '.');
+               for (idx = 0; idx < ROWLEN && ofs + idx < size; idx++)
+                       ascii[idx] = isgraph(buf[idx]) ? buf[idx] : '.';
+               ascii[idx] = '\0';
+               html_txt(ascii);
                html("</td></tr>\n");
        }
        html("</table>\n");