From 997707192d746620fa8f1c44d80e927ae44d1cfa Mon Sep 17 00:00:00 2001 From: patrick-scho Date: Thu, 22 Aug 2024 11:31:03 +0200 Subject: [PATCH] remove unneeded free's --- git.zig | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/git.zig b/git.zig index 80e9aac..07be390 100644 --- a/git.zig +++ b/git.zig @@ -322,11 +322,9 @@ const PackFile = struct { try self.pckFile.seekBy(-offset); const baseObject = try self.readObject(pckReader); - defer self.alloc.free(baseObject.data); try self.pckFile.seekTo(pos); const deltaData = try decompress(self.alloc, pckReader); - defer self.alloc.free(deltaData); const objectData = try applyDelta(self.alloc, baseObject.data, deltaData); return Object.init(baseObject.kind, objectData); @@ -390,7 +388,6 @@ const Repo = struct { pub fn getHead(self: *Repo) !Id { // read file HEAD const head = try self.dir.readFileAlloc(self.alloc, "HEAD", 1024); - defer self.alloc.free(head); // read file pointed at by HEAD const headPath = head[5 .. head.len - 1]; @@ -447,8 +444,6 @@ test "get object" { const head = try repo.getHead(); if (try repo.getObject(head)) |o| { - defer alloc.free(o.data); - std.debug.print("object({}): {s}\n", .{ o.kind, o.data }); } } @@ -464,8 +459,6 @@ test "parse commit" { const head = try repo.getHead(); if (try repo.getObject(head)) |o| { - defer alloc.free(o.data); - switch (try o.parse(alloc)) { .c => |c| { std.debug.print("commit:\n tree: {x}\n parent: {x}\n author: {s}\n committer: {s}\n message: {s}\n", .{ c.tree, c.parent, c.author, c.committer, c.message }); @@ -484,9 +477,7 @@ test "get tree" { defer repo.close(); if (try repo.getObject(0xceb2b2c62d6f8f3686dcacecd5be931839b02c77)) |o| { - defer alloc.free(o.data); - - // std.debug.print("tree({}): {any}\n", .{ o.kind, o.data }); + std.debug.print("tree({}): {any}\n", .{ o.kind, o.data }); } } @@ -499,8 +490,6 @@ test "parse tree" { defer repo.close(); if (try repo.getObject(0xceb2b2c62d6f8f3686dcacecd5be931839b02c77)) |o| { - defer alloc.free(o.data); - switch (try o.parse(alloc)) { .t => |t| { defer t.deinit(); @@ -527,8 +516,6 @@ test "list commits" { for (0..3) |_| { if (try repo.getObject(id)) |o| { - defer alloc.free(o.data); - switch (try o.parse(alloc)) { .c => |c| { std.debug.print("commit {x}:\n tree: {x}\n parent: {x}\n author: {s}\n committer: {s}\n message: {s}\n", .{ id, c.tree, c.parent, c.author, c.committer, c.message }); @@ -549,15 +536,11 @@ test "list blobs" { defer repo.close(); if (try repo.getObject(0xceb2b2c62d6f8f3686dcacecd5be931839b02c77)) |o| { - defer alloc.free(o.data); - switch (try o.parse(alloc)) { .t => |t| { defer t.deinit(); for (t.items) |treeEntry| { if (try repo.getObject(treeEntry.id)) |bo| { - defer alloc.free(bo.data); - if (treeEntry.permissions.len == 6) { std.debug.print("{s}: [{x} {}]{s}\n", .{ treeEntry.name, treeEntry.id, bo.data.len, bo.data[0..50] }); } else { @@ -585,8 +568,6 @@ test "basic frontend" { for (0..3) |_| { if (try repo.getObject(id)) |o| { - defer alloc.free(o.data); - switch (try o.parse(alloc)) { .c => |c| { std.debug.print("commit {x}:\n tree: {x}\n parent: {x}\n author: {s}\n committer: {s}\n message: {s}\n", .{ id, c.tree, c.parent, c.author, c.committer, c.message }); -- 2.50.1