From: John Keeping <john@keeping.me.uk>
Date: Mon, 1 Apr 2013 18:03:34 +0000 (+0100)
Subject: Fix out-of-bounds memory accesses with virtual_root=""
X-Git-Url: https://gitweb.ps.run/ps-cgit/commitdiff_plain/b1f17f168b91d709c0c0e62608de301a36f06da9?hp=b1f17f168b91d709c0c0e62608de301a36f06da9

Fix out-of-bounds memory accesses with virtual_root=""

The CGit configuration variable virtual_root is normalized so that it
does not have a trailing '/' character, but it is allowed to be empty
(the empty string and NULL have different meanings here) and there is
code that is insufficiently cautious when checking if it ends in a '/':

	if (virtual_root[strlen(virtual_root) - 1] != '/')

Clearly this check is redundant, but rather than simply removing it we
get a slight efficiency improvement by switching the normalization so
that the virtual_root variable always ends in '/'.  Do this with a new
"ensure_end" helper.

Signed-off-by: John Keeping <john@keeping.me.uk>
---