From: Lars Hjemli <hjemli@gmail.com>
Date: Tue, 12 Dec 2006 09:16:41 +0000 (+0100)
Subject: cache_lock: do xstrdup/free on lockfile
X-Git-Url: https://gitweb.ps.run/ps-cgit/commitdiff_plain/58d04f6523b0029281d65f841859fa42d0c744ff?hp=58d04f6523b0029281d65f841859fa42d0c744ff

cache_lock: do xstrdup/free on lockfile

Since fmt() uses 8 alternating static buffers, and cache_lock might call
cache_create_dirs() multiple times, which in turn might call fmt() twice,
after four iterations lockfile would be overwritten by a cachedirectory
path.

In worst case, this could cause the cachedirectory to be unlinked and replaced
by a cachefile.

Fix: use xstrdup() on the result from fmt() before assigning to lockfile, and
call free(lockfile) before exit.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---