From: Lars Hjemli <hjemli@gmail.com>
Date: Sun, 5 Oct 2008 17:25:47 +0000 (+0200)
Subject: ui-shared: use html_url_path() to get properly escaped url in form action
X-Git-Url: https://gitweb.ps.run/ps-cgit/commitdiff_plain/2e884f3162771880a2a5260713d6b7d1aa25bc6f?ds=sidebyside;hp=b7f33786ef4b155a11b0324f84bbde5d7fc9c998

ui-shared: use html_url_path() to get properly escaped url in form action

When a repo uses an url with e.g. '#' or '?' characters this needs to be
properly escaped when used as action in a form tag.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---

diff --git a/ui-shared.c b/ui-shared.c
index f858ab6..1e12529 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -649,8 +649,8 @@ void cgit_print_pageheader(struct cgit_context *ctx)
 		html("</td><td class='form'>");
 		html("<form class='right' method='get' action='");
 		if (ctx->cfg.virtual_root)
-			html_attr(cgit_fileurl(ctx->qry.repo, "log",
-					       ctx->qry.path, NULL));
+			html_url_path(cgit_fileurl(ctx->qry.repo, "log",
+						   ctx->qry.path, NULL));
 		html("'>\n");
 		add_hidden_formfields(1, 0, "log");
 		html("<select name='qt'>\n");