]> gitweb.ps.run Git - ps-cgit/commit
ui-stats: cast pointer before checking for zero
authorJohn Keeping <john@keeping.me.uk>
Mon, 8 Feb 2016 14:12:35 +0000 (14:12 +0000)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 8 Feb 2016 17:27:38 +0000 (18:27 +0100)
commitbdcbe0922d7099ebd61d875709ea9408bc1d7543
treedf225a74a832eb528e0686d6286bd8a5282eb633
parenta8b9ef8c1c68fbb9c89db2d8c12dca38c15e2bfd
ui-stats: cast pointer before checking for zero

We abuse the "void *util" field as a counter and recently started to
cast it to a uintptr_t to avoid risking nasal demons by performing
arithmetic on a void pointer.

However, compilers are also known to do "interesting" things if they
know that a pointer is or isn't NULL.  Make this safer by checking if
the counter (after casting) is non-zero rather than checking if the
pointer is non-null.

Signed-off-by: John Keeping <john@keeping.me.uk>
ui-stats.c