]> gitweb.ps.run Git - ps-cgit/commit
projects / ps-cgit / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a0bf375) | patch
Avoid null pointer dereference in cgit_print_diff().
authorLukas Fleischer <cgit@cryptocrack.de>
Tue, 5 Apr 2011 08:38:53 +0000 (10:38 +0200)
committerLars Hjemli <hjemli@gmail.com>
Mon, 23 May 2011 20:58:35 +0000 (22:58 +0200)
commit9afc883297b0d0943e9b358d2299950f33e8e5ed
tree27e81428c0a6ad4bbdf5633fc95b946b4a631d30tree | snapshot
parenta0bf375a1a9b74056a913f3687c6f5b42ad4acf6commit | diff
Avoid null pointer dereference in cgit_print_diff().

When calling cgit_print_diff() with a bad new_rev and a NULL old_rev,
checking for new_rev's parent commit will result in a null pointer
dereference. Returning on an invalid commit before dereferencing fixes
this. Spotted with clang-analyzer.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
ui-diff.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.