]> gitweb.ps.run Git - ps-cgit/commit
cache_lock: do xstrdup/free on lockfile
authorLars Hjemli <hjemli@gmail.com>
Tue, 12 Dec 2006 09:16:41 +0000 (10:16 +0100)
committerLars Hjemli <hjemli@gmail.com>
Tue, 12 Dec 2006 09:16:41 +0000 (10:16 +0100)
commit58d04f6523b0029281d65f841859fa42d0c744ff
treeed52e95047ccbb99152f7d3f009e57687e6452f1
parentfbaf1171b4e343929dd43ecac7cd9d1c692b84ec
cache_lock: do xstrdup/free on lockfile

Since fmt() uses 8 alternating static buffers, and cache_lock might call
cache_create_dirs() multiple times, which in turn might call fmt() twice,
after four iterations lockfile would be overwritten by a cachedirectory
path.

In worst case, this could cause the cachedirectory to be unlinked and replaced
by a cachefile.

Fix: use xstrdup() on the result from fmt() before assigning to lockfile, and
call free(lockfile) before exit.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
cache.c