]> gitweb.ps.run Git - ps-cgit/commit
cache: don't check for match with no key
authorJohn Keeping <john@keeping.me.uk>
Sat, 16 Jan 2016 11:03:07 +0000 (11:03 +0000)
committerJason A. Donenfeld <Jason@zx2c4.com>
Sun, 17 Jan 2016 16:05:39 +0000 (17:05 +0100)
commit33bc949a1e927e14479568518bd92e70998e25f8
tree4b31bd761caeea599aad3dad07d39341a900a112
parent3fbfced7401cfcbb8006a9a6ce4add6b37a41a55
cache: don't check for match with no key

We call open_slot() from cache_ls() without a key since we simply want
to read the path out of the header.  Should the file happen to contain
an empty key then we end up calling memcmp() with NULL and a non-zero
length.  Fix this by assigning slot->match only if a key is set, which
is always will be in the code paths where we use slot->match.

Coverity-id: 13807
Signed-off-by: John Keeping <john@keeping.me.uk>
cache.c