X-Git-Url: https://gitweb.ps.run/ps-cgit/blobdiff_plain/8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2..f072bc55b08675db93b2f892016e83d9f975dea2:/shared.c

diff --git a/shared.c b/shared.c
index a27ab30..6adf2b6 100644
--- a/shared.c
+++ b/shared.c
@@ -278,6 +278,10 @@ int cgit_diff_files(const unsigned char *old_sha1,
 	if ((file1.ptr && buffer_is_binary(file1.ptr, file1.size)) ||
 	    (file2.ptr && buffer_is_binary(file2.ptr, file2.size))) {
 		*binary = 1;
+		if (file1.size)
+			free(file1.ptr);
+		if (file2.size)
+			free(file2.ptr);
 		return 0;
 	}
 
@@ -290,6 +294,10 @@ int cgit_diff_files(const unsigned char *old_sha1,
 	emit_cb.outf = filediff_cb;
 	emit_cb.priv = fn;
 	xdl_diff(&file1, &file2, &diff_params, &emit_params, &emit_cb);
+	if (file1.size)
+		free(file1.ptr);
+	if (file2.size)
+		free(file2.ptr);
 	return 0;
 }
 
@@ -400,15 +408,16 @@ int cgit_close_filter(struct cgit_filter *filter)
  */
 int readfile(const char *path, char **buf, size_t *size)
 {
-	int fd;
+	int fd, e;
 	struct stat st;
 
 	fd = open(path, O_RDONLY);
 	if (fd == -1)
 		return errno;
 	if (fstat(fd, &st)) {
+		e = errno;
 		close(fd);
-		return errno;
+		return e;
 	}
 	if (!S_ISREG(st.st_mode)) {
 		close(fd);
@@ -416,7 +425,8 @@ int readfile(const char *path, char **buf, size_t *size)
 	}
 	*buf = xmalloc(st.st_size + 1);
 	*size = read_in_full(fd, *buf, st.st_size);
+	e = errno;
 	(*buf)[*size] = '\0';
 	close(fd);
-	return (*size == st.st_size ? 0 : errno);
+	return (*size == st.st_size ? 0 : e);
 }