log: allow users to follow a file

[ps-cgit] / cache.c

diff --git a/cache.c b/cache.c
index 9e7eeb0668dab1e9cb9cee0b231c2de1eef134fb..cd998127cc23e361cd9f53d9d988754fa5faa93d 100644 (file)
--- a/cache.c
+++ b/cache.c
@@ -161,10 +161,23 @@ static int close_lock(struct cache_slot *slot)
  */
 static int lock_slot(struct cache_slot *slot)
 {
-       slot->lock_fd = open(slot->lock_name, O_RDWR | O_CREAT | O_EXCL,
+       struct flock lock = {
+               .l_type = F_WRLCK,
+               .l_whence = SEEK_SET,
+               .l_start = 0,
+               .l_len = 0,
+       };
+
+       slot->lock_fd = open(slot->lock_name, O_RDWR | O_CREAT,
                             S_IRUSR | S_IWUSR);
        if (slot->lock_fd == -1)
                return errno;
+       if (fcntl(slot->lock_fd, F_SETLK, &lock) < 0) {
+               int saved_errno = errno;
+               close(slot->lock_fd);
+               slot->lock_fd = -1;
+               return saved_errno;
+       }
        if (xwrite(slot->lock_fd, slot->key, slot->keylen + 1) < 0)
                return errno;
        return 0;
@@ -343,7 +356,7 @@ int cache_process(int size, const char *path, const char *key, int ttl,
        int result;
 
        /* If the cache is disabled, just generate the content */
-       if (size <= 0) {
+       if (size <= 0 || ttl == 0) {
                fn();
                return 0;
        }
@@ -398,7 +411,7 @@ int cache_ls(const char *path)
        DIR *dir;
        struct dirent *ent;
        int err = 0;
-       struct cache_slot slot = { 0 };
+       struct cache_slot slot = { NULL };
        struct strbuf fullname = STRBUF_INIT;
        size_t prefixlen;