ui-log: Prevent crash when given empty range search

[ps-cgit] / ui-log.c

diff --git a/ui-log.c b/ui-log.c
index 7f38d2acb41dc9fe451c3ba9f133eb81794b71d9..b9771fa772599c73029e7dec351475e363d2360d 100644 (file)
--- a/ui-log.c
+++ b/ui-log.c
@@ -101,7 +101,7 @@ void print_commit(struct commit *commit)
                files = 0;
                add_lines = 0;
                rem_lines = 0;
                files = 0;
                add_lines = 0;
                rem_lines = 0;

-               cgit_diff_commit(commit, inspect_files);
+               cgit_diff_commit(commit, inspect_files, ctx.qry.vpath);

                html("</td><td>");
                htmlf("%d", files);
                if (ctx.repo->enable_log_linecount) {
                html("</td><td>");
                htmlf("%d", files);
                if (ctx.repo->enable_log_linecount) {


@@ -112,7 +112,7 @@ void print_commit(struct commit *commit)
        html("</td></tr>\n");
        if (ctx.qry.showmsg) {
                struct strbuf notes = STRBUF_INIT;
        html("</td></tr>\n");
        if (ctx.qry.showmsg) {
                struct strbuf notes = STRBUF_INIT;

-               get_commit_notes(commit, &notes, PAGE_ENCODING, 0);
+               format_note(NULL, commit->object.sha1, &notes, PAGE_ENCODING, 0);

 
                if (ctx.repo->enable_log_filecount) {
                        cols++;
 
                if (ctx.repo->enable_log_filecount) {
                        cols++;


@@ -162,7 +162,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
 
        argv[1] = disambiguate_ref(tip);
 
 
        argv[1] = disambiguate_ref(tip);
 

-       if (grep && pattern) {
+       if (grep && pattern && *pattern) {

                if (!strcmp(grep, "grep") || !strcmp(grep, "author") ||
                    !strcmp(grep, "committer"))
                        argv[argc++] = fmt("--%s=%s", grep, pattern);
                if (!strcmp(grep, "grep") || !strcmp(grep, "author") ||
                    !strcmp(grep, "committer"))
                        argv[argc++] = fmt("--%s=%s", grep, pattern);


@@ -228,8 +228,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
                commit->parents = NULL;
        }
        if (pager) {
                commit->parents = NULL;
        }
        if (pager) {

-               htmlf("</table><div class='pager'>",
-                    columns);
+               html("</table><div class='pager'>");

                if (ofs > 0) {
                        cgit_log_link("[prev]", NULL, NULL, ctx.qry.head,
                                      ctx.qry.sha1, ctx.qry.vpath,
                if (ofs > 0) {
                        cgit_log_link("[prev]", NULL, NULL, ctx.qry.head,
                                      ctx.qry.sha1, ctx.qry.vpath,