ui-shared: use strcmp() to compare strings

[ps-cgit] / ui-diff.c

diff --git a/ui-diff.c b/ui-diff.c
index 7ec5701a4ea668990572b3088cd004f7d2dfc7bd..5c864d926777670de0ddf449c96b0e016c294b4c 100644 (file)
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -31,43 +31,85 @@ static void print_line(char *line, int len)
        line[len-1] = c;
 }
 
-static void header(unsigned char *sha1, char *path1,
-                  unsigned char *sha2, char *path2)
+static void header(unsigned char *sha1, char *path1, int mode1,
+                  unsigned char *sha2, char *path2, int mode2)
 {
        char *abbrev1, *abbrev2;
+       int subproject;
 
-       html("<tr><td>");
+       subproject = (S_ISDIRLNK(mode1) || S_ISDIRLNK(mode2));
        html("<div class='head'>");
        html("diff --git a/");
        html_txt(path1);
        html(" b/");
        html_txt(path2);
-       abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
-       abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV));
-       htmlf("\nindex %s..%s", abbrev1, abbrev2);
-       free(abbrev1);
-       free(abbrev2);
-       html("\n--- a/");
-       html_txt(path1);
-       html("\n+++ b/");
-       html_txt(path2);
+
+       if (is_null_sha1(sha1))
+               path1 = "dev/null";
+       if (is_null_sha1(sha2))
+               path2 = "dev/null";
+
+       if (mode1 == 0)
+               htmlf("<br/>new file mode %.6o", mode2);
+
+       if (mode2 == 0)
+               htmlf("<br/>deleted file mode %.6o", mode1);
+
+       if (!subproject) {
+               abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
+               abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV));
+               htmlf("<br/>index %s..%s", abbrev1, abbrev2);
+               free(abbrev1);
+               free(abbrev2);
+               if (mode1 != 0 && mode2 != 0) {
+                       htmlf(" %.6o", mode1);
+                       if (mode2 != mode1)
+                               htmlf("..%.6o", mode2);
+               }
+               html("<br/>--- a/");
+               html_txt(path1);
+               html("<br/>+++ b/");
+               html_txt(path2);
+       }
        html("</div>");
 }
 
 static void filepair_cb(struct diff_filepair *pair)
 {
-       header(pair->one->sha1, pair->one->path,
-              pair->two->sha1, pair->two->path);
+       header(pair->one->sha1, pair->one->path, pair->one->mode,
+              pair->two->sha1, pair->two->path, pair->two->mode);
+       if (S_ISDIRLNK(pair->one->mode) || S_ISDIRLNK(pair->two->mode)) {
+               if (S_ISDIRLNK(pair->one->mode))
+                       print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52);
+               if (S_ISDIRLNK(pair->two->mode))
+                       print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52);
+               return;
+       }
        if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line))
                cgit_print_error("Error running diff");
-       html("</tr></td>");
 }
 
-void cgit_print_diff(const char *old_hex, const char *new_hex, char *path)
+void cgit_print_diff(const char *head, const char *old_hex, const char *new_hex, char *path)
 {
        unsigned char sha1[20], sha2[20];
        enum object_type type;
        unsigned long size;
+       struct commit *commit;
+
+       html("<table class='diff'>");
+       html("<tr><td>");
+
+       if (head && !old_hex && !new_hex) {
+               get_sha1(head, sha1);
+               commit = lookup_commit_reference(sha1);
+               if (commit && !parse_commit(commit))
+                       cgit_diff_commit(commit, filepair_cb);
+               else
+                       cgit_print_error(fmt("Bad commit: %s", head));
+               html("</td></tr>");
+               html("</table>");
+               return;
+       }
 
        get_sha1(old_hex, sha1);
        get_sha1(new_hex, sha2);
@@ -81,14 +123,11 @@ void cgit_print_diff(const char *old_hex, const char *new_hex, char *path)
                }
        }
 
-       html("<table class='diff'>");
        switch(type) {
        case OBJ_BLOB:
-               html("<tr><td>");
-               header(sha1, path, sha2, path);
+               header(sha1, path, 0644, sha2, path, 0644);
                if (cgit_diff_files(sha1, sha2, print_line))
                        cgit_print_error("Error running diff");
-               html("</tr></td>");
                break;
        case OBJ_TREE:
                cgit_diff_tree(sha1, sha2, filepair_cb);
@@ -98,5 +137,6 @@ void cgit_print_diff(const char *old_hex, const char *new_hex, char *path)
                                     typename(type)));
                break;
        }
-       html("</td></tr></table>");
+       html("</td></tr>");
+       html("</table>");
 }