ui-snapshot: replace 'unsigned char sha1[20]' with 'struct object_id oid'

[ps-cgit] / ui-snapshot.c

diff --git a/ui-snapshot.c b/ui-snapshot.c
index 053fd48803ee47a52a5f1fa314c0f0ef9ff3bbdc..08c6e80550e1147d920611f1c29c9ad1c882ce7d 100644 (file)
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -1,116 +1,220 @@
 /* ui-snapshot.c: generate snapshot of a commit
  *
 /* ui-snapshot.c: generate snapshot of a commit
  *

- * Copyright (C) 2006 Lars Hjemli
+ * Copyright (C) 2006-2014 cgit Development Team <cgit@lists.zx2c4.com>

  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"

+#include "ui-snapshot.h"
+#include "html.h"
+#include "ui-shared.h"

 
 

-static int write_compressed_tar_archive(struct archiver_args *args,const char *filter)
+static int write_archive_type(const char *format, const char *hex, const char *prefix)

 {
 {

-       int rw[2];
-       pid_t gzpid;
-       int stdout2;
-       int status;
-       int rv;
-
-       stdout2 = chk_non_negative(dup(STDIN_FILENO), "Preserving STDOUT before compressing");
-       chk_zero(pipe(rw), "Opening pipe from compressor subprocess");
-       gzpid = chk_non_negative(fork(), "Forking compressor subprocess");
-       if(gzpid==0) {
-               /* child */
-               chk_zero(close(rw[1]), "Closing write end of pipe in child");
-               chk_zero(close(STDIN_FILENO), "Closing STDIN");
-               chk_non_negative(dup2(rw[0],STDIN_FILENO), "Redirecting compressor input to stdin");
-               execlp(filter,filter,NULL);
-               _exit(-1);
+       struct argv_array argv = ARGV_ARRAY_INIT;
+       const char **nargv;
+       int result;
+       argv_array_push(&argv, "snapshot");
+       argv_array_push(&argv, format);
+       if (prefix) {
+               struct strbuf buf = STRBUF_INIT;
+               strbuf_addstr(&buf, prefix);
+               strbuf_addch(&buf, '/');
+               argv_array_push(&argv, "--prefix");
+               argv_array_push(&argv, buf.buf);
+               strbuf_release(&buf);

        }
        }

-       /* parent */
-       chk_zero(close(rw[0]), "Closing read end of pipe");
-       chk_non_negative(dup2(rw[1],STDOUT_FILENO), "Redirecting output to compressor");
-       
-       rv = write_tar_archive(args);
-
-       chk_zero(close(STDOUT_FILENO), "Closing STDOUT redirected to compressor");
-       chk_non_negative(dup2(stdout2,STDOUT_FILENO), "Restoring uncompressed STDOUT");
-       chk_zero(close(stdout2), "Closing uncompressed STDOUT");
-       chk_zero(close(rw[1]), "Closing write end of pipe in parent");
-       chk_positive(waitpid(gzpid,&status,0), "Waiting on compressor process");
-       if(! ( WIFEXITED(status) && WEXITSTATUS(status)==0 ) )
-               cgit_print_error("Failed to compress archive");
+       argv_array_push(&argv, hex);
+       /*
+        * Now we need to copy the pointers to arguments into a new
+        * structure because write_archive will rearrange its arguments
+        * which may result in duplicated/missing entries causing leaks
+        * or double-frees in argv_array_clear.
+        */
+       nargv = xmalloc(sizeof(char *) * (argv.argc + 1));
+       /* argv_array guarantees a trailing NULL entry. */
+       memcpy(nargv, argv.argv, sizeof(char *) * (argv.argc + 1));
+
+       result = write_archive(argv.argc, nargv, NULL, 1, NULL, 0);
+       argv_array_clear(&argv);
+       free(nargv);
+       return result;
+}
+
+static int write_tar_archive(const char *hex, const char *prefix)
+{
+       return write_archive_type("--format=tar", hex, prefix);
+}
+
+static int write_zip_archive(const char *hex, const char *prefix)
+{
+       return write_archive_type("--format=zip", hex, prefix);
+}
+
+static int write_compressed_tar_archive(const char *hex,
+                                       const char *prefix,
+                                       char *filter_argv[])
+{
+       int rv;
+       struct cgit_exec_filter f;
+       cgit_exec_filter_init(&f, filter_argv[0], filter_argv);

 
 

+       cgit_open_filter(&f.base);
+       rv = write_tar_archive(hex, prefix);
+       cgit_close_filter(&f.base);

        return rv;
 }
 
        return rv;
 }
 

-static int write_tar_gzip_archive(struct archiver_args *args)
+static int write_tar_gzip_archive(const char *hex, const char *prefix)

 {
 {

-       return write_compressed_tar_archive(args,"gzip");
+       char *argv[] = { "gzip", "-n", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);

 }
 }

-static int write_tar_bzip2_archive(struct archiver_args *args)
+
+static int write_tar_bzip2_archive(const char *hex, const char *prefix)
+{
+       char *argv[] = { "bzip2", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);
+}
+
+static int write_tar_xz_archive(const char *hex, const char *prefix)

 {
 {

-       return write_compressed_tar_archive(args,"bzip2");
+       char *argv[] = { "xz", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);

 }
 
 }
 

-static const struct snapshot_archive_t {
-       const char *suffix;
-       const char *mimetype;
-       write_archive_fn_t write_func;
-}      snapshot_archives[] = {
-       { ".zip", "application/x-zip", write_zip_archive },
-       { ".tar.gz", "application/x-tar", write_tar_gzip_archive },
-       { ".tar.bz2", "application/x-tar", write_tar_bzip2_archive },
-       { ".tar", "application/x-tar", write_tar_archive }
+const struct cgit_snapshot_format cgit_snapshot_formats[] = {
+       { ".zip", "application/x-zip", write_zip_archive, 0x01 },
+       { ".tar.gz", "application/x-gzip", write_tar_gzip_archive, 0x02 },
+       { ".tar.bz2", "application/x-bzip2", write_tar_bzip2_archive, 0x04 },
+       { ".tar", "application/x-tar", write_tar_archive, 0x08 },
+       { ".tar.xz", "application/x-xz", write_tar_xz_archive, 0x10 },
+       { NULL }

 };
 
 };
 

-void cgit_print_snapshot(struct cacheitem *item, const char *hex, 
-                        const char *prefix, const char *filename)
+static const struct cgit_snapshot_format *get_format(const char *filename)

 {
 {

-       int fnl = strlen(filename);
-       int f;
-       for(f=0;f<(sizeof(snapshot_archives)/sizeof(*snapshot_archives));++f) {
-               const struct snapshot_archive_t* sat = &snapshot_archives[f];
-               int sl = strlen(sat->suffix);
-               if(fnl<sl || strcmp(&filename[fnl-sl],sat->suffix))
-                       continue;
-
-               struct archiver_args args;
-               struct commit *commit;
-               unsigned char sha1[20];
-
-               if(get_sha1(hex, sha1)) {
-                       cgit_print_error(fmt("Bad object id: %s", hex));
-                       return;
-               }
-               commit = lookup_commit_reference(sha1);
+       const struct cgit_snapshot_format *fmt;

 
 

-               if(!commit) {
-                       cgit_print_error(fmt("Not a commit reference: %s", hex));
-                       return;;
-               }
+       for (fmt = cgit_snapshot_formats; fmt->suffix; fmt++) {
+               if (ends_with(filename, fmt->suffix))
+                       return fmt;
+       }
+       return NULL;
+}

 
 

-               memset(&args,0,sizeof(args));
-               args.base = fmt("%s/", prefix);
-               args.tree = commit->tree;
+static int make_snapshot(const struct cgit_snapshot_format *format,
+                        const char *hex, const char *prefix,
+                        const char *filename)
+{
+       struct object_id oid;

 
 

-               cgit_print_snapshot_start(sat->mimetype, filename, item);
-               (*sat->write_func)(&args);
-               return;
+       if (get_oid(hex, &oid)) {
+               cgit_print_error_page(404, "Not found",
+                               "Bad object id: %s", hex);
+               return 1;
+       }
+       if (!lookup_commit_reference(oid.hash)) {
+               cgit_print_error_page(400, "Bad request",
+                               "Not a commit reference: %s", hex);
+               return 1;

        }
        }

-       cgit_print_error(fmt("Unsupported snapshot format: %s", filename));
+       ctx.page.etag = oid_to_hex(&oid);
+       ctx.page.mimetype = xstrdup(format->mimetype);
+       ctx.page.filename = xstrdup(filename);
+       cgit_print_http_headers();
+       format->write_func(hex, prefix);
+       return 0;

 }
 
 }
 

-void cgit_print_snapshot_links(const char *repo,const char *hex)
+/* Try to guess the requested revision from the requested snapshot name.
+ * First the format extension is stripped, e.g. "cgit-0.7.2.tar.gz" become
+ * "cgit-0.7.2". If this is a valid commit object name we've got a winner.
+ * Otherwise, if the snapshot name has a prefix matching the result from
+ * repo_basename(), we strip the basename and any following '-' and '_'
+ * characters ("cgit-0.7.2" -> "0.7.2") and check the resulting name once
+ * more. If this still isn't a valid commit object name, we check if pre-
+ * pending a 'v' or a 'V' to the remaining snapshot name ("0.7.2" ->
+ * "v0.7.2") gives us something valid.
+ */
+static const char *get_ref_from_filename(const char *url, const char *filename,
+                                        const struct cgit_snapshot_format *format)

 {
 {

-       char *filename;
-       int f;
-       for(f=0;f<(sizeof(snapshot_archives)/sizeof(*snapshot_archives));++f) {
-               const struct snapshot_archive_t* sat = &snapshot_archives[f];
-               filename = fmt("%s-%s%s",cgit_repobasename(repo),hex,sat->suffix);
-               htmlf("<a href='%s'>%s</a><br/>",
-                       cgit_fileurl(repo,"snapshot",filename,
-                           fmt("id=%s&amp;name=%s",hex,filename)), filename);
+       const char *reponame;
+       struct object_id oid;
+       struct strbuf snapshot = STRBUF_INIT;
+       int result = 1;
+
+       strbuf_addstr(&snapshot, filename);
+       strbuf_setlen(&snapshot, snapshot.len - strlen(format->suffix));
+
+       if (get_oid(snapshot.buf, &oid) == 0)
+               goto out;
+
+       reponame = cgit_repobasename(url);
+       if (starts_with(snapshot.buf, reponame)) {
+               const char *new_start = snapshot.buf;
+               new_start += strlen(reponame);
+               while (new_start && (*new_start == '-' || *new_start == '_'))
+                       new_start++;
+               strbuf_splice(&snapshot, 0, new_start - snapshot.buf, "", 0);

        }
        }

+
+       if (get_oid(snapshot.buf, &oid) == 0)
+               goto out;
+
+       strbuf_insert(&snapshot, 0, "v", 1);
+       if (get_oid(snapshot.buf, &oid) == 0)
+               goto out;
+
+       strbuf_splice(&snapshot, 0, 1, "V", 1);
+       if (get_oid(snapshot.buf, &oid) == 0)
+               goto out;
+
+       result = 0;
+       strbuf_release(&snapshot);
+
+out:
+       return result ? strbuf_detach(&snapshot, NULL) : NULL;
+}
+
+void cgit_print_snapshot(const char *head, const char *hex,
+                        const char *filename, int dwim)
+{
+       const struct cgit_snapshot_format* f;
+       char *prefix = NULL;
+
+       if (!filename) {
+               cgit_print_error_page(400, "Bad request",
+                               "No snapshot name specified");
+               return;
+       }
+
+       f = get_format(filename);
+       if (!f) {
+               cgit_print_error_page(400, "Bad request",
+                               "Unsupported snapshot format: %s", filename);
+               return;
+       }
+
+       if (!hex && dwim) {
+               hex = get_ref_from_filename(ctx.repo->url, filename, f);
+               if (hex == NULL) {
+                       cgit_print_error_page(404, "Not found", "Not found");
+                       return;
+               }
+               prefix = xstrdup(filename);
+               prefix[strlen(filename) - strlen(f->suffix)] = '\0';
+       }
+
+       if (!hex)
+               hex = head;
+
+       if (!prefix)
+               prefix = xstrdup(cgit_repobasename(ctx.repo->url));
+
+       make_snapshot(f, hex, prefix, filename);
+       free(prefix);

 }
 }

-/* vim:set sw=8: */