fix building with clang

[ps-cgit] / cache.c

diff --git a/cache.c b/cache.c
index b169d20f779aaa21ed5c3bd8e4e21c62500a0c90..1c843ba873d00152263a0005a0e0dd8d230c752b 100644 (file)
--- a/cache.c
+++ b/cache.c
@@ -24,11 +24,12 @@
 
 struct cache_slot {
        const char *key;
-       int keylen;
+       size_t keylen;
        int ttl;
        cache_fill_fn fn;
        int cache_fd;
        int lock_fd;
+       int stdout_fd;
        const char *cache_name;
        const char *lock_name;
        int match;
@@ -44,7 +45,7 @@ struct cache_slot {
 static int open_slot(struct cache_slot *slot)
 {
        char *bufz;
-       int bufkeylen = -1;
+       ssize_t bufkeylen = -1;
 
        slot->cache_fd = open(slot->cache_name, O_RDONLY);
        if (slot->cache_fd == -1)
@@ -61,8 +62,9 @@ static int open_slot(struct cache_slot *slot)
        if (bufz)
                bufkeylen = bufz - slot->buf;
 
-       slot->match = bufkeylen == slot->keylen &&
-           !memcmp(slot->key, slot->buf, bufkeylen + 1);
+       if (slot->key)
+               slot->match = bufkeylen == slot->keylen &&
+                   !memcmp(slot->key, slot->buf, bufkeylen + 1);
 
        return 0;
 }
@@ -83,40 +85,45 @@ static int close_slot(struct cache_slot *slot)
 /* Print the content of the active cache slot (but skip the key). */
 static int print_slot(struct cache_slot *slot)
 {
+       off_t off;
 #ifdef HAVE_LINUX_SENDFILE
-       off_t start_off;
-       int ret;
+       off_t size;
+#endif
+
+       off = slot->keylen + 1;
 
-       start_off = slot->keylen + 1;
+#ifdef HAVE_LINUX_SENDFILE
+       size = slot->cache_st.st_size;
 
        do {
-               ret = sendfile(STDOUT_FILENO, slot->cache_fd, &start_off,
-                               slot->cache_st.st_size - start_off);
+               ssize_t ret;
+               ret = sendfile(STDOUT_FILENO, slot->cache_fd, &off, size - off);
                if (ret < 0) {
                        if (errno == EAGAIN || errno == EINTR)
                                continue;
+                       /* Fall back to read/write on EINVAL or ENOSYS */
+                       if (errno == EINVAL || errno == ENOSYS)
+                               break;
                        return errno;
                }
-               return 0;
+               if (off == size)
+                       return 0;
        } while (1);
-#else
-       ssize_t i, j;
+#endif
 
-       i = lseek(slot->cache_fd, slot->keylen + 1, SEEK_SET);
-       if (i != slot->keylen + 1)
+       if (lseek(slot->cache_fd, off, SEEK_SET) != off)
                return errno;
 
        do {
-               i = j = xread(slot->cache_fd, slot->buf, sizeof(slot->buf));
-               if (i > 0)
-                       j = xwrite(STDOUT_FILENO, slot->buf, i);
-       } while (i > 0 && j == i);
-
-       if (i < 0 || j != i)
-               return errno;
-       else
-               return 0;
-#endif
+               ssize_t ret;
+               ret = xread(slot->cache_fd, slot->buf, sizeof(slot->buf));
+               if (ret < 0)
+                       return errno;
+               if (ret == 0)
+                       return 0;
+               if (write_in_full(STDOUT_FILENO, slot->buf, ret) < 0)
+                       return errno;
+       } while (1);
 }
 
 /* Check if the slot has expired */
@@ -196,6 +203,13 @@ static int unlock_slot(struct cache_slot *slot, int replace_old_slot)
        else
                err = unlink(slot->lock_name);
 
+       /* Restore stdout and close the temporary FD. */
+       if (slot->stdout_fd >= 0) {
+               dup2(slot->stdout_fd, STDOUT_FILENO);
+               close(slot->stdout_fd);
+               slot->stdout_fd = -1;
+       }
+
        if (err)
                return errno;
 
@@ -207,36 +221,24 @@ static int unlock_slot(struct cache_slot *slot, int replace_old_slot)
  */
 static int fill_slot(struct cache_slot *slot)
 {
-       int tmp;
-
        /* Preserve stdout */
-       tmp = dup(STDOUT_FILENO);
-       if (tmp == -1)
+       slot->stdout_fd = dup(STDOUT_FILENO);
+       if (slot->stdout_fd == -1)
                return errno;
 
        /* Redirect stdout to lockfile */
-       if (dup2(slot->lock_fd, STDOUT_FILENO) == -1) {
-               close(tmp);
+       if (dup2(slot->lock_fd, STDOUT_FILENO) == -1)
                return errno;
-       }
 
        /* Generate cache content */
        slot->fn();
 
-       /* update stat info */
-       if (fstat(slot->lock_fd, &slot->cache_st)) {
-               close(tmp);
+       /* Make sure any buffered data is flushed to the file */
+       if (fflush(stdout))
                return errno;
-       }
 
-       /* Restore stdout */
-       if (dup2(tmp, STDOUT_FILENO) == -1) {
-               close(tmp);
-               return errno;
-       }
-
-       /* Close the temporary filedescriptor */
-       if (close(tmp))
+       /* update stat info */
+       if (fstat(slot->lock_fd, &slot->cache_st))
                return errno;
 
        return 0;
@@ -311,7 +313,7 @@ static int process_slot(struct cache_slot *slot)
        /* If the cache slot does not exist (or its key doesn't match the
         * current key), lets try to create a new cache slot for this
         * request. If this fails (for whatever reason), lets just generate
-        * the content without caching it and fool the caller to belive
+        * the content without caching it and fool the caller to believe
         * everything worked out (but print a warning on stdout).
         */
 
@@ -386,6 +388,7 @@ int cache_process(int size, const char *path, const char *key, int ttl,
        strbuf_addstr(&lockname, ".lock");
        slot.fn = fn;
        slot.ttl = ttl;
+       slot.stdout_fd = -1;
        slot.cache_name = filename.buf;
        slot.lock_name = lockname.buf;
        slot.key = key;
@@ -403,12 +406,12 @@ int cache_process(int size, const char *path, const char *key, int ttl,
 static char *sprintftime(const char *format, time_t time)
 {
        static char buf[64];
-       struct tm *tm;
+       struct tm tm;
 
        if (!time)
                return NULL;
-       tm = gmtime(&time);
-       strftime(buf, sizeof(buf)-1, format, tm);
+       gmtime_r(&time, &tm);
+       strftime(buf, sizeof(buf)-1, format, &tm);
        return buf;
 }