ui-atom: fix resource leak: free before return

[ps-cgit] / ui-atom.c

diff --git a/ui-atom.c b/ui-atom.c
index b218456b6e0f4ddc3b57a42f6e542bec31b4be2b..fab4b0fd8d50bbb83b2129227394e65f606f058a 100644 (file)
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -1,16 +1,17 @@
 /* ui-atom.c: functions for atom feeds
  *
- * Copyright (C) 2008 Lars Hjemli
+ * Copyright (C) 2006-2014 cgit Development Team <cgit@lists.zx2c4.com>
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"
+#include "ui-atom.h"
 #include "html.h"
 #include "ui-shared.h"
 
-void add_entry(struct commit *commit, char *host)
+static void add_entry(struct commit *commit, const char *host)
 {
        char delim = '&';
        char *hex;
@@ -107,7 +108,7 @@ void cgit_print_atom(char *tip, char *path, int max_count)
        host = cgit_hosturl();
        ctx.page.mimetype = "text/xml";
        ctx.page.charset = "utf-8";
-       cgit_print_http_headers(&ctx);
+       cgit_print_http_headers();
        html("<feed xmlns='http://www.w3.org/2005/Atom'>\n");
        html("<title>");
        html_txt(ctx.repo->name);
@@ -124,18 +125,20 @@ void cgit_print_atom(char *tip, char *path, int max_count)
        html_txt(ctx.repo->desc);
        html("</subtitle>\n");
        if (host) {
+               char *repourl = cgit_repourl(ctx.repo->url);
                html("<link rel='alternate' type='text/html' href='");
                html(cgit_httpscheme());
                html_attr(host);
-               html_attr(cgit_repourl(ctx.repo->url));
+               html_attr(repourl);
                html("'/>\n");
+               free(repourl);
        }
        while ((commit = get_revision(&rev)) != NULL) {
                add_entry(commit, host);
-               free(commit->buffer);
-               commit->buffer = NULL;
+               free_commit_buffer(commit);
                free_commit_list(commit->parents);
                commit->parents = NULL;
        }
        html("</feed>\n");
+       free(host);
 }