- if (commit->parents && commit->parents->item)
- hashcpy(old_sha1, commit->parents->item->object.sha1);
- else
- hashclr(old_sha1);
+ if (old_rev) {
+ if (get_sha1(old_rev, old_rev_sha1)) {
+ cgit_print_error("Bad object id: %s", old_rev);
+ return;
+ }
+ if (!lookup_commit_reference(old_rev_sha1)) {
+ cgit_print_error("Bad commit reference: %s", old_rev);
+ return;
+ }
+ } else if (commit->parents && commit->parents->item) {
+ hashcpy(old_rev_sha1, commit->parents->item->object.sha1);
+ } else {
+ hashclr(old_rev_sha1);
+ }
+
+ if (is_null_sha1(old_rev_sha1)) {
+ memcpy(rev_range, sha1_to_hex(new_rev_sha1), 41);
+ } else {
+ sprintf(rev_range, "%s..%s", sha1_to_hex(old_rev_sha1),
+ sha1_to_hex(new_rev_sha1));
+ }