Free reflists after usage

[ps-cgit] / ui-log.c

diff --git a/ui-log.c b/ui-log.c
index b930bb245d58248add16c8c125df43bab30cea6a..857c05c01f7a7ac26dd79078f9710ef7019ace7f 100644 (file)
--- a/ui-log.c
+++ b/ui-log.c
@@ -7,70 +7,385 @@
  */
 
 #include "cgit.h"
  */
 
 #include "cgit.h"

+#include "html.h"
+#include "ui-shared.h"
+#include "vector.h"

 
 

-int files, lines;
+int files, add_lines, rem_lines;

 
 

-void inspect_files(struct diff_filepair *pair)
+/*
+ * The list of available column colors in the commit graph.
+ */
+static const char *column_colors_html[] = {
+       "<span class='column1'>",
+       "<span class='column2'>",
+       "<span class='column3'>",
+       "<span class='column4'>",
+       "<span class='column5'>",
+       "<span class='column6'>",
+       "</span>",
+};
+
+#define COLUMN_COLORS_HTML_MAX (ARRAY_SIZE(column_colors_html) - 1)
+
+static void count_lines(char *line, int size)

 {
 {

+       if (size <= 0)
+               return;
+
+       if (line[0] == '+')
+               add_lines++;
+
+       else if (line[0] == '-')
+               rem_lines++;
+}
+
+static void inspect_files(struct diff_filepair *pair)
+{
+       unsigned long old_size = 0;
+       unsigned long new_size = 0;
+       int binary = 0;
+

        files++;
        files++;

+       if (ctx.repo->enable_log_linecount)
+               cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size,
+                               &new_size, &binary, 0, ctx.qry.ignorews,
+                               count_lines);

 }
 
 }
 

-void print_commit(struct commit *commit)
+void show_commit_decorations(struct commit *commit)
+{
+       struct name_decoration *deco;
+       static char buf[1024];
+
+       buf[sizeof(buf) - 1] = 0;
+       deco = lookup_decoration(&name_decoration, &commit->object);
+       while (deco) {
+               if (!prefixcmp(deco->name, "refs/heads/")) {
+                       strncpy(buf, deco->name + 11, sizeof(buf) - 1);
+                       cgit_log_link(buf, NULL, "branch-deco", buf, NULL,
+                                     ctx.qry.vpath, 0, NULL, NULL,
+                                     ctx.qry.showmsg);
+               }
+               else if (!prefixcmp(deco->name, "tag: refs/tags/")) {
+                       strncpy(buf, deco->name + 15, sizeof(buf) - 1);
+                       cgit_tag_link(buf, NULL, "tag-deco", ctx.qry.head, buf);
+               }
+               else if (!prefixcmp(deco->name, "refs/tags/")) {
+                       strncpy(buf, deco->name + 10, sizeof(buf) - 1);
+                       cgit_tag_link(buf, NULL, "tag-deco", ctx.qry.head, buf);
+               }
+               else if (!prefixcmp(deco->name, "refs/remotes/")) {
+                       if (!ctx.repo->enable_remote_branches)
+                               goto next;
+                       strncpy(buf, deco->name + 13, sizeof(buf) - 1);
+                       cgit_log_link(buf, NULL, "remote-deco", NULL,
+                                     sha1_to_hex(commit->object.sha1),
+                                     ctx.qry.vpath, 0, NULL, NULL,
+                                     ctx.qry.showmsg);
+               }
+               else {
+                       strncpy(buf, deco->name, sizeof(buf) - 1);
+                       cgit_commit_link(buf, NULL, "deco", ctx.qry.head,
+                                        sha1_to_hex(commit->object.sha1),
+                                        ctx.qry.vpath, 0);
+               }
+next:
+               deco = deco->next;
+       }
+}
+
+static void print_commit(struct commit *commit, struct rev_info *revs)

 {
 {

-       char buf[32];

        struct commitinfo *info;
        struct commitinfo *info;

-       struct tm *time;
+       int cols = revs->graph ? 3 : 2;
+       struct strbuf graphbuf = STRBUF_INIT;
+       struct strbuf msgbuf = STRBUF_INIT;
+
+       if (ctx.repo->enable_log_filecount)
+               cols++;
+       if (ctx.repo->enable_log_linecount)
+               cols++;
+
+       if (revs->graph) {
+               /* Advance graph until current commit */
+               while (!graph_next_line(revs->graph, &graphbuf)) {
+                       /* Print graph segment in otherwise empty table row */
+                       html("<tr class='nohover'><td class='commitgraph'>");
+                       html(graphbuf.buf);
+                       htmlf("</td><td colspan='%d' /></tr>\n", cols);
+                       strbuf_setlen(&graphbuf, 0);
+               }
+               /* Current commit's graph segment is now ready in graphbuf */
+       }

 
        info = cgit_parse_commit(commit);
 
        info = cgit_parse_commit(commit);

-       time = gmtime(&commit->date);
-       html("<tr><td>");
-       strftime(buf, sizeof(buf), "%Y-%m-%d %H:%M", time);
-       html_txt(buf);
-       html("</td><td>");
-       char *qry = fmt("id=%s", sha1_to_hex(commit->object.sha1));
-       char *url = cgit_pageurl(cgit_query_repo, "commit", qry);
-       html_link_open(url, NULL, NULL);
-       html_ntxt(cgit_max_msg_len, info->subject);
-       html_link_close();
-       html("</td><td class='right'>");
-       files = 0;
-       lines = 0;
-       cgit_diff_commit(commit, inspect_files);
-       htmlf("%d", files);
+       htmlf("<tr%s>", ctx.qry.showmsg ? " class='logheader'" : "");
+
+       if (revs->graph) {
+               /* Print graph segment for current commit */
+               html("<td class='commitgraph'>");
+               html(graphbuf.buf);
+               html("</td>");
+               strbuf_setlen(&graphbuf, 0);
+       }
+       else {
+               html("<td>");
+               cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
+               html("</td>");
+       }
+
+       htmlf("<td%s>", ctx.qry.showmsg ? " class='logsubject'" : "");
+       if (ctx.qry.showmsg) {
+               /* line-wrap long commit subjects instead of truncating them */
+               size_t subject_len = strlen(info->subject);
+
+               if (subject_len > ctx.cfg.max_msg_len &&
+                   ctx.cfg.max_msg_len >= 15) {
+                       /* symbol for signaling line-wrap (in PAGE_ENCODING) */
+                       const char wrap_symbol[] = { ' ', 0xE2, 0x86, 0xB5, 0 };
+                       int i = ctx.cfg.max_msg_len - strlen(wrap_symbol);
+
+                       /* Rewind i to preceding space character */
+                       while (i > 0 && !isspace(info->subject[i]))
+                               --i;
+                       if (!i) /* Oops, zero spaces. Reset i */
+                               i = ctx.cfg.max_msg_len - strlen(wrap_symbol);
+
+                       /* add remainder starting at i to msgbuf */
+                       strbuf_add(&msgbuf, info->subject + i, subject_len - i);
+                       strbuf_trim(&msgbuf);
+                       strbuf_add(&msgbuf, "\n\n", 2);
+
+                       /* Place wrap_symbol at position i in info->subject */
+                       strcpy(info->subject + i, wrap_symbol);
+               }
+       }
+       cgit_commit_link(info->subject, NULL, NULL, ctx.qry.head,
+                        sha1_to_hex(commit->object.sha1), ctx.qry.vpath, 0);
+       show_commit_decorations(commit);

        html("</td><td>");
        html_txt(info->author);
        html("</td><td>");
        html_txt(info->author);

+
+       if (revs->graph) {
+               html("</td><td>");
+               cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
+       }
+
+       if (ctx.repo->enable_log_filecount || ctx.repo->enable_log_linecount) {
+               files = 0;
+               add_lines = 0;
+               rem_lines = 0;
+               cgit_diff_commit(commit, inspect_files, ctx.qry.vpath);
+       }
+
+       if (ctx.repo->enable_log_filecount)
+               htmlf("</td><td>%d", files);
+       if (ctx.repo->enable_log_linecount)
+               htmlf("</td><td>-%d/+%d", rem_lines, add_lines);
+

        html("</td></tr>\n");
        html("</td></tr>\n");

+
+       if (revs->graph || ctx.qry.showmsg) { /* Print a second table row */
+               html("<tr class='nohover'>");
+
+               if (ctx.qry.showmsg) {
+                       /* Concatenate commit message + notes in msgbuf */
+                       if (info->msg && *(info->msg)) {
+                               strbuf_addstr(&msgbuf, info->msg);
+                               strbuf_addch(&msgbuf, '\n');
+                       }
+                       format_note(NULL, commit->object.sha1, &msgbuf,
+                                   PAGE_ENCODING,
+                                   NOTES_SHOW_HEADER | NOTES_INDENT);
+                       strbuf_addch(&msgbuf, '\n');
+                       strbuf_ltrim(&msgbuf);
+               }
+
+               if (revs->graph) {
+                       int lines = 0;
+
+                       /* Calculate graph padding */
+                       if (ctx.qry.showmsg) {
+                               /* Count #lines in commit message + notes */
+                               const char *p = msgbuf.buf;
+                               lines = 1;
+                               while ((p = strchr(p, '\n'))) {
+                                       p++;
+                                       lines++;
+                               }
+                       }
+
+                       /* Print graph padding */
+                       html("<td class='commitgraph'>");
+                       while (lines > 0 || !graph_is_commit_finished(revs->graph)) {
+                               if (graphbuf.len)
+                                       html("\n");
+                               strbuf_setlen(&graphbuf, 0);
+                               graph_next_line(revs->graph, &graphbuf);
+                               html(graphbuf.buf);
+                               lines--;
+                       }
+                       html("</td>\n");
+               }
+               else
+                       html("<td/>"); /* Empty 'Age' column */
+
+               /* Print msgbuf into remainder of table row */
+               htmlf("<td colspan='%d'%s>\n", cols,
+                       ctx.qry.showmsg ? " class='logmsg'" : "");
+               html_txt(msgbuf.buf);
+               html("</td></tr>\n");
+       }
+
+       strbuf_release(&msgbuf);
+       strbuf_release(&graphbuf);

        cgit_free_commitinfo(info);
 }
 
        cgit_free_commitinfo(info);
 }
 

+static const char *disambiguate_ref(const char *ref)
+{
+       unsigned char sha1[20];
+       const char *longref;
+
+       longref = fmt("refs/heads/%s", ref);
+       if (get_sha1(longref, sha1) == 0)
+               return longref;

 
 

-void cgit_print_log(const char *tip, int ofs, int cnt, char *grep)
+       return ref;
+}
+
+static char *next_token(char **src)
+{
+       char *result;
+
+       if (!src || !*src)
+               return NULL;
+       while (isspace(**src))
+               (*src)++;
+       if (!**src)
+               return NULL;
+       result = *src;
+       while (**src) {
+               if (isspace(**src)) {
+                       **src = '\0';
+                       (*src)++;
+                       break;
+               }
+               (*src)++;
+       }
+       return result;
+}
+
+void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern,
+                   char *path, int pager, int commit_graph, int commit_sort)

 {
        struct rev_info rev;
        struct commit *commit;
 {
        struct rev_info rev;
        struct commit *commit;

-       const char *argv[3] = {NULL, tip, NULL};
-       int argc = 2;
-       int i;
+       struct vector vec = VECTOR_INIT(char *);
+       int i, columns = 3;
+       char *arg;
+
+       /* First argv is NULL */
+       vector_push(&vec, NULL, 0);
+
+       if (!tip)
+               tip = ctx.qry.head;
+       tip = disambiguate_ref(tip);
+       vector_push(&vec, &tip, 0);
+
+       if (grep && pattern && *pattern) {
+               pattern = xstrdup(pattern);
+               if (!strcmp(grep, "grep") || !strcmp(grep, "author") ||
+                   !strcmp(grep, "committer")) {
+                       arg = fmt("--%s=%s", grep, pattern);
+                       vector_push(&vec, &arg, 0);
+               }
+               if (!strcmp(grep, "range")) {
+                       /* Split the pattern at whitespace and add each token
+                        * as a revision expression. Do not accept other
+                        * rev-list options. Also, replace the previously
+                        * pushed tip (it's no longer relevant).
+                        */
+                       vec.count--;
+                       while ((arg = next_token(&pattern))) {
+                               if (*arg == '-') {
+                                       fprintf(stderr, "Bad range expr: %s\n",
+                                               arg);
+                                       break;
+                               }
+                               vector_push(&vec, &arg, 0);
+                       }
+               }
+       }
+       if (commit_graph) {
+               static const char *graph_arg = "--graph";
+               static const char *color_arg = "--color";
+               vector_push(&vec, &graph_arg, 0);
+               vector_push(&vec, &color_arg, 0);
+               graph_set_column_colors(column_colors_html,
+                                       COLUMN_COLORS_HTML_MAX);
+       }
+
+       if (commit_sort == 1) {
+               static const char *date_order_arg = "--date-order";
+               vector_push(&vec, &date_order_arg, 0);
+       } else if (commit_sort == 2) {
+               static const char *topo_order_arg = "--topo-order";
+               vector_push(&vec, &topo_order_arg, 0);
+       }
+
+       if (path) {
+               arg = "--";
+               vector_push(&vec, &arg, 0);
+               vector_push(&vec, &path, 0);
+       }
+
+       /* Make sure the vector is NULL-terminated */
+       vector_push(&vec, NULL, 0);
+       vec.count--;

 
 

-       if (grep)
-               argv[argc++] = fmt("--grep=%s", grep);

        init_revisions(&rev, NULL);
        rev.abbrev = DEFAULT_ABBREV;
        rev.commit_format = CMIT_FMT_DEFAULT;
        rev.verbose_header = 1;
        rev.show_root_diff = 0;
        init_revisions(&rev, NULL);
        rev.abbrev = DEFAULT_ABBREV;
        rev.commit_format = CMIT_FMT_DEFAULT;
        rev.verbose_header = 1;
        rev.show_root_diff = 0;

-       setup_revisions(argc, argv, &rev, NULL);
-       if (rev.grep_filter) {
-               rev.grep_filter->regflags |= REG_ICASE;
-               compile_grep_patterns(rev.grep_filter);
-       }
+       setup_revisions(vec.count, vec.data, &rev, NULL);
+       load_ref_decorations(DECORATE_FULL_REFS);
+       rev.show_decorations = 1;
+       rev.grep_filter.regflags |= REG_ICASE;
+       compile_grep_patterns(&rev.grep_filter);

        prepare_revision_walk(&rev);
 
        prepare_revision_walk(&rev);
 

-       html("<table class='list nowrap'>");
-       html("<tr class='nohover'><th class='left'>Date</th>"
-            "<th class='left'>Message</th>"
-            "<th class='left'>Files</th>"
-            "<th class='left'>Author</th></tr>\n");
+       if (pager)
+               html("<table class='list nowrap'>");
+
+       html("<tr class='nohover'>");
+       if (commit_graph)
+               html("<th></th>");
+       else
+               html("<th class='left'>Age</th>");
+       html("<th class='left'>Commit message");
+       if (pager) {
+               html(" (");
+               cgit_log_link(ctx.qry.showmsg ? "Collapse" : "Expand", NULL,
+                             NULL, ctx.qry.head, ctx.qry.sha1,
+                             ctx.qry.vpath, ctx.qry.ofs, ctx.qry.grep,
+                             ctx.qry.search, ctx.qry.showmsg ? 0 : 1);
+               html(")");
+       }
+       html("</th><th class='left'>Author</th>");
+       if (commit_graph)
+               html("<th class='left'>Age</th>");
+       if (ctx.repo->enable_log_filecount) {
+               html("<th class='left'>Files</th>");
+               columns++;
+       }
+       if (ctx.repo->enable_log_linecount) {
+               html("<th class='left'>Lines</th>");
+               columns++;
+       }
+       html("</tr>\n");

 
        if (ofs<0)
                ofs = 0;
 
        if (ofs<0)
                ofs = 0;


@@ -83,28 +398,32 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep)
        }
 
        for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) {
        }
 
        for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) {

-               print_commit(commit);
+               print_commit(commit, &rev);

                free(commit->buffer);
                commit->buffer = NULL;
                free_commit_list(commit->parents);
                commit->parents = NULL;
        }
                free(commit->buffer);
                commit->buffer = NULL;
                free_commit_list(commit->parents);
                commit->parents = NULL;
        }

-       html("</table>\n");
-
-       html("<div class='pager'>");
-       if (ofs > 0) {
-               html("&nbsp;<a href='");
-               html(cgit_pageurl(cgit_query_repo, cgit_query_page,
-                                 fmt("h=%s&ofs=%d", tip, ofs-cnt)));
-               html("'>[prev]</a>&nbsp;");
-               }
-
-       if ((commit = get_revision(&rev)) != NULL) {
-               html("&nbsp;<a href='");
-               html(cgit_pageurl(cgit_query_repo, "log",
-                                 fmt("h=%s&ofs=%d", tip, ofs+cnt)));
-               html("'>[next]</a>&nbsp;");
+       if (pager) {
+               html("</table><div class='pager'>");
+               if (ofs > 0) {
+                       cgit_log_link("[prev]", NULL, NULL, ctx.qry.head,
+                                     ctx.qry.sha1, ctx.qry.vpath,
+                                     ofs - cnt, ctx.qry.grep,
+                                     ctx.qry.search, ctx.qry.showmsg);
+                       html("&nbsp;");
+               }
+               if ((commit = get_revision(&rev)) != NULL) {
+                       cgit_log_link("[next]", NULL, NULL, ctx.qry.head,
+                                     ctx.qry.sha1, ctx.qry.vpath,
+                                     ofs + cnt, ctx.qry.grep,
+                                     ctx.qry.search, ctx.qry.showmsg);
+               }
+               html("</div>");
+       } else if ((commit = get_revision(&rev)) != NULL) {
+               html("<tr class='nohover'><td colspan='3'>");
+               cgit_log_link("[...]", NULL, NULL, ctx.qry.head, NULL,
+                             ctx.qry.vpath, 0, NULL, NULL, ctx.qry.showmsg);
+               html("</td></tr>\n");

        }
        }

-       html("</div>");

 }
 }

-