cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

[ps-cgit] / cmd.c

diff --git a/cmd.c b/cmd.c
index c9910928a6878daef6165e258ae4ec2c6b50c20f..3093c62a5f1fc581e35d86c0d2f265cf0e4b4091 100644 (file)
--- a/cmd.c
+++ b/cmd.c
@@ -41,9 +41,13 @@ static void about_fn(void)
        if (ctx.repo) {
                if (!ctx.qry.path &&
                    ctx.qry.url[strlen(ctx.qry.url) - 1] != '/' &&
        if (ctx.repo) {
                if (!ctx.qry.path &&
                    ctx.qry.url[strlen(ctx.qry.url) - 1] != '/' &&

-                   ctx.env.path_info[strlen(ctx.env.path_info) - 1] != '/')
-                       cgit_redirect(fmtalloc("%s/", cgit_currenturl()), true);
-               else
+                   ctx.env.path_info[strlen(ctx.env.path_info) - 1] != '/') {
+                       char *currenturl = cgit_currenturl();
+                       char *redirect = fmtalloc("%s/", currenturl);
+                       cgit_redirect(redirect, true);
+                       free(currenturl);
+                       free(redirect);
+               } else

                        cgit_print_repo_readme(ctx.qry.path);
        } else
                cgit_print_site_readme();
                        cgit_print_repo_readme(ctx.qry.path);
        } else
                cgit_print_site_readme();