git: update to v2.46.0

[ps-cgit] / ui-clone.c

diff --git a/ui-clone.c b/ui-clone.c
index 2c1ac3daa8e827f49afc2f369a18456867f153b9..df196a04614cc5a9aae44e8beb8b2398d3c88c80 100644 (file)
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -7,6 +7,8 @@
  *   (see COPYING for full license text)
  */
 
  *   (see COPYING for full license text)
  */
 

+#define USE_THE_REPOSITORY_VARIABLE
+

 #include "cgit.h"
 #include "ui-clone.h"
 #include "html.h"
 #include "cgit.h"
 #include "ui-clone.h"
 #include "html.h"


@@ -19,12 +21,12 @@ static int print_ref_info(const char *refname, const struct object_id *oid,
 {
        struct object *obj;
 
 {
        struct object *obj;
 

-       if (!(obj = parse_object(oid)))
+       if (!(obj = parse_object(the_repository, oid)))

                return 0;
 
        htmlf("%s\t%s\n", oid_to_hex(oid), refname);
        if (obj->type == OBJ_TAG) {
                return 0;
 
        htmlf("%s\t%s\n", oid_to_hex(oid), refname);
        if (obj->type == OBJ_TAG) {

-               if (!(obj = deref_tag(obj, refname, 0)))
+               if (!(obj = deref_tag(the_repository, obj, refname, 0)))

                        return 0;
                htmlf("%s\t%s^{}\n", oid_to_hex(&obj->oid), refname);
        }
                        return 0;
                htmlf("%s\t%s^{}\n", oid_to_hex(&obj->oid), refname);
        }


@@ -87,22 +89,38 @@ void cgit_clone_info(void)
        ctx.page.mimetype = "text/plain";
        ctx.page.filename = "info/refs";
        cgit_print_http_headers();
        ctx.page.mimetype = "text/plain";
        ctx.page.filename = "info/refs";
        cgit_print_http_headers();

-       for_each_ref(print_ref_info, NULL);
+       refs_for_each_ref(get_main_ref_store(the_repository),
+                         print_ref_info, NULL);

 }
 
 void cgit_clone_objects(void)
 {
 }
 
 void cgit_clone_objects(void)
 {

-       if (!ctx.qry.path) {
-               cgit_print_error_page(400, "Bad request", "Bad request");
-               return;
-       }
+       char *p;
+
+       if (!ctx.qry.path)
+               goto err;

 
        if (!strcmp(ctx.qry.path, "info/packs")) {
                print_pack_info();
                return;
        }
 
 
        if (!strcmp(ctx.qry.path, "info/packs")) {
                print_pack_info();
                return;
        }
 

+       /* Avoid directory traversal by forbidding "..", but also work around
+        * other funny business by just specifying a fairly strict format. For
+        * example, now we don't have to stress out about the Cygwin port.
+        */
+       for (p = ctx.qry.path; *p; ++p) {
+               if (*p == '.' && *(p + 1) == '.')
+                       goto err;
+               if (!isalnum(*p) && *p != '/' && *p != '.' && *p != '-')
+                       goto err;
+       }
+

        send_file(git_path("objects/%s", ctx.qry.path));
        send_file(git_path("objects/%s", ctx.qry.path));

+       return;
+
+err:
+       cgit_print_error_page(400, "Bad request", "Bad request");

 }
 
 void cgit_clone_head(void)
 }
 
 void cgit_clone_head(void)